[WIP] Feature #3417 - Implement tuiDropdownDirectionChange & tuiHintDirectionChange #9645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiv9604
requested review from
MarsiBarsi,
waterplea,
nsbarsukov,
vladimirpotekhin and
mdlufy
and removed request for
a team
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
BundleMonFiles updated (1)
Unchanged files (4)
Total files change +133B +0.02% Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
shiv9604
force-pushed
the
feature/3417-dropdown-hint-direction-change
branch
from
9f85746 to
014c744
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9645 +/- ##
==========================================
- Coverage 75.68% 75.23% -0.45%
==========================================
Files 1216 1248 +32
Lines 19068 19600 +532
Branches 2091 2090 -1
==========================================
+ Hits 14432 14747 +315
- Misses 4592 4807 +215
- Partials 44 46 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
waterplea
reviewed
Nov 5, 2024
waterplea
requested changes
Nov 7, 2024
shiv9604
force-pushed
the
feature/3417-dropdown-hint-direction-change
branch
from
959fd4d to
c0624d6
Compare
waterplea
reviewed
Nov 9, 2024
| @@ -57,10 +56,13 @@ export class TuiDropdownPositionSided extends TuiPositionAccessor { | |||
| (available[this.previous] > minHeight && direction) || | |||
| this.previous === better | |||
| ) { | |||
| this.vertical.emitDirection(better); | |||
There was a problem hiding this comment.
It should be this.previous here
| const better: TuiVerticalDirection = | ||
| available.top > available.bottom ? 'top' : 'bottom'; | ||
|
|
||
| this.emitDirection(better); |
There was a problem hiding this comment.
It's not always better, sometimes it's previous, see if on the next line.
| .t-textfield-icon | ||
| ::ng-deep | ||
| [tuiAppearance][data-appearance='icon']::after { | ||
| :host:not(._readonly):not(._disabled):hover .t-textfield-icon ::ng-deep [tuiAppearance][data-appearance='icon']::after { |
There was a problem hiding this comment.
Weird that this got affected 🤔 You should rollback those style changes. Maybe you need to run npm i to update some lint config packages locally?
| @@ -10,13 +10,12 @@ import {TuiDropdownPosition} from './dropdown-position.directive'; | |||
| @Directive({ | |||
| standalone: true, | |||
| selector: '[tuiDropdownSided]', | |||
| providers: [TuiDropdownPosition, tuiAsPositionAccessor(TuiDropdownPositionSided)], | |||
| providers: [tuiAsPositionAccessor(TuiDropdownPositionSided)], | |||
There was a problem hiding this comment.
Looks like this was still necessary. Please put it back — I'll investigate myself later how so.
splincode
changed the title
Co-authored-by: taiga-family-bot <taiga-family-bot@users.noreply.github.com>
Co-authored-by: taiga-family-bot <taiga-family-bot@users.noreply.github.com>
…mily#9579) Co-authored-by: taiga-family-bot <taiga-family-bot@users.noreply.github.com>
…aiga-family#9648) Co-authored-by: Alexandr Shakirov <al.a.shakirov@tinkoff.ru>
…iga-family#9711) Co-authored-by: taiga-family-bot <taiga-family-bot@users.noreply.github.com>
…Bar` (taiga-family#9654) Co-authored-by: 40oleg <oleg.merkulov701@gmail.com> Co-authored-by: taiga-family-bot <taiga-family-bot@users.noreply.github.com>
…a-family#9715) Co-authored-by: taiga-family-bot <taiga-family-bot@users.noreply.github.com>
shiv9604
force-pushed
the
feature/3417-dropdown-hint-direction-change
branch
from
e711ab7 to
9f49f6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #3417